[PATCH] server: Move the \BaseNamedObjects symlink from \Sessions\0 to \Sessions\1\BaseNamedObjects.

flan flan at flande.re
Thu Jul 7 20:05:49 CDT 2016


On Fri, Jul 08, 2016 at 01:17:01AM +0200, Sebastian Lackner wrote:
> I'm not the maintainer of this component, but Alex is right that you
> will have to use your real name (both as author and also in the
> Signed-off-by message).
> 
> I also believe that the variable names link_bno1W and link_bno1_str
> are chosen a bit badly. The 1 does not really make any sense, and instead
> of "bno" it might be better to use the same abbreviation "basenamed" as
> above. If you make any changes, please also adjust the whitespace
> inbetween of the variable name and "=" to match the surrounding code.
> 
> If \\Sessions\\1 contains all the elements from \\, you could also
> think about symlinking it to root (instead of symlinking each component
> separately).
> 
> Regards,
> Sebastian
> 

Thank you for the feedback, I'll change variable names and adjust the
whitespace. \\Sessions\\1 does not seem to contain all elements from \\. The
only element besides BaseNamedObjects that's both in \\ and \\Sessions\\1
seems to be \\Windows and its child directory, WindowStations.

Is there any particular reason behind the real name requirement?



More information about the wine-devel mailing list