libport: Mark internal functions and data tables as hidden.

[Francois Gouget]

On Tue, 1 Mar 2016, Alexandre Julliard wrote:

> Francois Gouget <fgouget at free.fr> writes:
> 
> > I had not tried to remove it only from the externs. It seems to do the 
> > trick, except for wine_decompose() in libs/port/decompose.c where I get 
> > the following error if I don't remove the DECLSPEC_HIDDEN:
> >
> > gcc -o libwine.so.1.0 casemap.o collation.o config.o debug.o ldt.o loader.o mmap.o port.o sortkey.o string.o \
> >   wctype.o version.o -shared -Wl,-soname,libwine.so.1 ../../libs/port/libwine_port.a -lsocket -lnsl \
> >   
> > Text relocation remains                 	referenced
> >     against symbol		    offset	in file
> > wine_decompose                      0x76      	../../libs/port/libwine_port.a(decompose.o)
> >
> > I've included what seems to be the minimal patch below:
> 
> Is wine_compose also an issue, even though it's not called from libwine?

Yes. It's strange. If I remove the wine_compose() parts of the patch I 
get:

gcc -o libwine.so.1.0 casemap.o collation.o config.o debug.o ldt.o loader.o mmap.o port.o sortkey.o string.o \
  wctype.o version.o -shared -Wl,-soname,libwine.so.1 ../../libs/port/libwine_port.a -lsocket -lnsl \
  
Text relocation remains                 	referenced
    against symbol		    offset	in file
wine_compose                        0x7ce     	../../libs/port/libwine_port.a(utf8.o)
wine_compose                        0x8df     	../../libs/port/libwine_port.a(utf8.o)
wine_compose                        0x75f     	../../libs/port/libwine_port.a(wctomb.o)
wine_compose                        0x8ec     	../../libs/port/libwine_port.a(wctomb.o)
wine_compose                        0x9a9     	../../libs/port/libwine_port.a(wctomb.o)
wine_compose                        0xa89     	../../libs/port/libwine_port.a(wctomb.o)
ld: fatal: relocations remain against allocatable but non-writable sections


I'm trying a Solaris upgrade to see if it makes a difference.

-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
              E-Voting: It's not the people who vote that count.
                     It's the people who count the votes.