[PATCH] d3dx9: IsParameterUsed stub should return TRUE.

[Matteo Bruni]

2016-03-07 23:09 GMT+01:00 Henri Verbeet <hverbeet at gmail.com>:
> On 7 March 2016 at 22:49, Matteo Bruni <matteo.mystral at gmail.com> wrote:
>> Yes, I guess returning TRUE is usually more likely to work. Of course
> Is that necessarily what you want though? It might be harder to debug
> something being slow because it's updating unused parameters than to
> debug something rendering incorrectly because it's not updating them.

There is still the FIXME() and it shouldn't be impossible to figure
out if there are redundant parameter updates.
OTOH I guess failing to draw correctly is a much bigger incentive to
implement the function properly... I don't know, I don't feel too
strongly either way.

>> a proper implementation would be even better (although it may be non
>> obvious to find out if a parameter is used, depending on what "used"
>> really means - it needs tests)...
> You always need tests, but a reasonable guess would be whether the
> parameter is referenced by the technique.

That's likely to be the case, but yeah - tests.