[PATCH] riched20: Implement ITextRange::ScrollIntoView.

Huw Davies huw at codeweavers.com
Tue Mar 22 04:09:39 CDT 2016


On Fri, Mar 18, 2016 at 11:59:52AM -0700, Adam Buchbinder wrote:
> diff --git a/dlls/riched20/tests/richole.c b/dlls/riched20/tests/richole.c
> index 7c6c5d5..de3c7a0 100644
> --- a/dlls/riched20/tests/richole.c
> +++ b/dlls/riched20/tests/richole.c
> @@ -53,6 +53,7 @@ static HWND new_window(LPCSTR lpClassName, DWORD dwStyle, HWND parent)
>    HWND hwnd = CreateWindowA(lpClassName, NULL,
>                              dwStyle | WS_POPUP | WS_HSCROLL | WS_VSCROLL | WS_VISIBLE,
>                              0, 0, 200, 60, parent, NULL, hmoduleRichEdit, NULL);
> +  ok(hwnd != NULL, "class: %s, error: %d\n", lpClassName, (int) GetLastError());
>    return hwnd;
>  }
>  
> @@ -761,6 +762,66 @@ static void test_ITextRange_GetChar(void)
>    ITextRange_Release(txtRge);
>  }
>  
> +/* Helper function for testing ITextRange_ScrollIntoView */
> +static void check_range(HWND w, ITextDocument* doc, int first, int lim,
> +                        LONG bStart, int expected_nonzero) {

Please put the opening brace on a new line.

More importantly, I get a test failure:
richole.c:785: Test failed: Moved scrollbar is at 60, should be 0. (Range 0-160.)

Huw.



More information about the wine-devel mailing list