[PATCH 3/6] d3drm: Implement IDirect3DRM*_CreateTexture. (v4)

[Aaryaman Vasishta]

I just realized I can avoid calling d3drm_validate_image() there by just
returning D3DRMERR_BADVALUE if InitFromImage fails. Is that fine?

On Wed, May 11, 2016 at 10:53 PM, Aaryaman Vasishta <
jem456.vasishta at gmail.com> wrote:

> Right, it's actually for the different return values, sorry to not mention
> it earlier.
>
> Cheers,
> Aaryaman
>
>
> On Wed, May 11, 2016 at 10:16 PM, Henri Verbeet <hverbeet at gmail.com>
> wrote:
>
>> On 11 May 2016 at 17:50, Aaryaman Vasishta <jem456.vasishta at gmail.com>
>> wrote:
>> > If CreateTexture fails because of an invalid image, it doesn't leak a
>> > reference to d3drm, unlike the InitFrom* calls. So I had to either do
>> this,
>> > or explicitly release texture->d3drm if InitFromImage fails.
>> >
>> That's not what the implementation in patch 2/6 does. It will leak if
>> the texture is already initialised, but not when
>> d3drm_validate_image() fails.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160511/a44939dc/attachment.html>