[PATCH 3/4] ddraw/tests: Don'T use DDBLT_COLORFILL in test_flip.

Henri Verbeet hverbeet at gmail.com
Tue Apr 18 06:01:29 CDT 2017


On 17 April 2017 at 22:14, Stefan Dösinger <stefan at codeweavers.com> wrote:
> +/* The Nvidia Geforce 7 driver cannot do a color fill on a texture backbuffer after
> + * the backbuffer has been locked. Do it ourselves as a workaround. Unlike ddraw1
> + * and 2 GetSurfaceDesc does not cause issues in ddraw4 and ddraw7. */
> +static void fill_surface(IDirectDrawSurface7 *surface, D3DCOLOR color)
I think this kind of helper is fine, but the comment seems more
appropriate for the place using it than the helper itself.

> +        color = get_surface_color(backbuffer1, 320, 240);
> +        color = get_surface_color(backbuffer2, 320, 240);
> +        color = get_surface_color(backbuffer3, 320, 240);
Is this debug code?



More information about the wine-devel mailing list