[PATCH 01/2] dpnet/test: Share code between tests (resend)

[Alistair Leslie-Hughes]

Hi Erich,

On 07/02/17 15:39, Erich E. Hoover wrote:
> On Mon, Jan 30, 2017 at 12:05 AM, Alistair Leslie-Hughes
> <leslie_alistair at hotmail.com> wrote:
>> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
>> ---
>>  dlls/dpnet/tests/address.c       |  28 +-------
>>  dlls/dpnet/tests/client.c        | 150 +--------------------------------------
>>  dlls/dpnet/tests/dpnet_private.h |  32 +++++++++
>>  dlls/dpnet/tests/server.c        |  16 ++---
>> ...
> 
> I have never seen a "*_private.h" header in any of the other tests,
> though there are a small number of "*_test.h" headers.  This instance
> might be _especially_ confusing since it would result in both a
> "./dlls/dpnet/dpnet_private.h" and a
> "./dlls/dpnet/tests/dpnet_private.h".  The second patch looks
> reasonable to me, though you may wish for others to weigh in.
> 
Thanks for the review.
I'm happy to rename the header  if thats all is needed to get
it committed. I'll assume dpnet_test.h is fine unless someone else
states something different.

Best Regards
Alistair