[PATCH] dbghelp: Always return a dos path from SymGetLineFromAddr

[Alistair Leslie-Hughes]

Hi Huw,

Thanks for the review.

On 07/02/17 22:17, Huw Davies wrote:
> On Mon, Jan 30, 2017 at 07:04:51AM +0000, Alistair Leslie-Hughes wrote:
> 
> This has implications for winedbg that at least need to be discussed.
> For example, with this patch, backtraces contain Windows-like paths.
> I imagine there will be more serious issues too.
I didn't think on how it would affect winedbg. Windows compatible first
then I'll fix the compatible issue with winedbg.

> 
> For the patch itself, you now have a Unicode string, so it would make
> sense to have symt_fill_func_line_info() return that, then switch the
> dependencies so that SymGetLineFromAddr64() calls
> SymGetLineFromAddrW64().  To create the ANSI buffer, you probably
> want to use fetch_buffer() rather than a static array.
This sounds like a good idea.

Best Regards
 Alistair.