[PATCH 2/2] comctl32/propsheet: Implement PSPCB_ADDREF/PSPCB_RELEASE notifications

[Dmitry Timoshkov]

Nikolay Sivov <bunglehead at gmail.com> wrote:

> >> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
> >> ---
> >>  dlls/comctl32/propsheet.c       | 41 +++++++++++++++++++++++++++++++++++------
> >>  dlls/comctl32/tests/propsheet.c |  4 ----
> >>  2 files changed, 35 insertions(+), 10 deletions(-)
> > 
> > And of course it's a pure coincidence that you immediately started to work on
> > PSPCB_ADDREF/PSPCB_RELEASE once a patch for it has been added to wine-staging.
> 
> Why should or shouldn't it be? What does it have to do with a patch? I
> worked on getting another propsheet fix tracked in wine-staging in, as
> well as some of my own. Simply because I care about fixes getting into
> Wine, you - apparently not so much.

Apparently the fact that wine-staging is an official part of the Wine
project means not that much for you.

> > I'd suggest to stop such ill-behaved practices, or at least give a credit to
> > the source if you decided to "borrow" an idea. Or is this an indication that
> > you just ran out of your own ideas to work on? :)
> > 
> 
> I would gladly give a credit for it, if it worked in a first place.
> Since it couldn't possibly work, and behavior is well documented, I
> don't think it qualifies as an idea on its own.

The wine-staging patch worked well for an application it was tagetting
(Process Hacker), what is an application name that it didn't work for?

> Now, to get all the credit you can possibly get, because that's
> obviously is the most important thing there is, there is a way that
> you're well aware of.

I just pointed out to an ill-behaving practices you're using, and asked
to either stop doing such bad things, or give a credit to the source.
Since the original wine-staging patch is pretty trivial it's not a big
problem in this case, but taking into account your practice to "borrow"
wine-staging work it may become a real problem at some point, at least
as a distorted image of the company you are working for.

P.S.
Thanks for confirming that the wine-staging patch was the starting point
of your work.

-- 
Dmitry.