[PATCH 3/5] usp10: Use heap_alloc_zero() instead of HeapAlloc() with HEAP_ZERO_MEMORY.

[Aric Stewart]

On 3/9/17 9:02 AM, Henri Verbeet wrote:
> On 9 March 2017 at 15:51, Sebastian Lackner <sebastian at fds-team.de> wrote:
>> On 09.03.2017 10:37, Henri Verbeet wrote:
>>> -static inline BOOL heap_free(void *mem)
>>> -{
>>> -    return HeapFree(GetProcessHeap(), 0, mem);
>>> -}
>> [...]
>>> +static inline void heap_free(void *mem)
>>> +{
>>> +    HeapFree(GetProcessHeap(), 0, mem);
>>> +}
>>
>> I'm not sure if Francois is happy with this change. In other dlls, he
>> has made the exact opposite change in his effort to standardize those
>> functions.
>>
> I wasn't aware of that. While I don't care particularly much if it's
> there or not, I'd be somewhat surprised if there are legitimate uses
> of the return value. At least inside usp10 it's always ignored.
> 
> 

I personally have no passion either way either. Having it be void vs BOOL is all the same to me.
Francois? Do you care, if so then I think your caring will win. :)

To not slow down my review I will ignore this issue and look at the rest. Since I don't care my resulting sign-offs will reflect that. 

-aric