[4/4] kernel32: Add localized version resource.

Alexandre Julliard julliard at winehq.org
Wed Mar 15 12:29:36 CDT 2017


Akihiro Sagawa <sagawa.aki at gmail.com> writes:

> On Wed, 15 Mar 2017 09:49:30 +0100, Alexandre Julliard wrote:
>> Akihiro Sagawa <sagawa.aki at gmail.com> writes:
>> 
>> > diff --git a/dlls/kernel32/version.rc b/dlls/kernel32/version.rc
>> > index 411bd6e..dbaee67 100644
>> > --- a/dlls/kernel32/version.rc
>> > +++ b/dlls/kernel32/version.rc
>> > @@ -16,6 +16,13 @@
>> >   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>> >   */
>> >  
>> > +#include "winresrc.h"
>> > +
>> > +#pragma makedep po
>> > +
>> > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
>> > +
>> > +#define WINE_FILEDESCRIPTION_STR "#msgctxt#kernel32#Wine Core DLL"
>> >  #define WINE_FILENAME_STR "kernel32.dll"
>> 
>> Is there a reason that this needs to be kernel32 specific? Why couldn't
>> other dlls use the translation too?
>
> Thanks for your comments. From my point of view, only translation for
> kernel32 is needed because that is cause of Bug 41757. How about using
> specific text for kernel32, like "Wine kernel DLL", and keeping
> untranslated for other DLLs?

Yes, a more descriptive name unique to kernel32 would be better. I don't
think we should be abusing message contexts for that sort of thing.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list