[PATCH 1/3] odbccp32: Implement SQLInstallTranslator

Hans Leidekker hans at codeweavers.com
Wed Mar 22 06:33:11 CDT 2017


On Wed, 2017-03-22 at 00:14 +0000, Alistair Leslie-Hughes wrote:
> +        reg_ret = RegOpenKeyExA(HKEY_LOCAL_MACHINE, "Software\\ODBC\\ODBCINST.INI\\WINE ODBC Translator", 0, KEY_READ, &hkey);
> +        ok(reg_ret == ERROR_SUCCESS, "RegOpenKeyExW failed\n");
> +        if (reg_ret == ERROR_SUCCESS)
> +        {
> +            DWORD type, size = MAX_PATH;
> +            char driverpath[MAX_PATH];
> +
> +            strcpy(driverpath, syspath);
> +            strcat(driverpath, "\\sample.dll");
> +
> +            reg_ret = RegGetValueA(hkey, NULL, "Translator", RRF_RT_REG_SZ, &type, &path, &size);
> +            ok(reg_ret == ERROR_SUCCESS, "RegGetValueA failed\n");
> +            ok(!strcmp(path, driverpath), "invalid path %s\n", path);

RegGetValueA is not available on XP. A warning dialog is shown but it's never closed,
which can cause failures in tests that follow:

https://testbot.winehq.org/JobDetails.pl?Key=29622&scrshot_101=1#k101

I've submitted a patch that avoids RegGetValueA. Please do something similar in these patches.





More information about the wine-devel mailing list