[v7 1/5] server: Named pipe query SD from pipe object

[Jacek Caban]

Hi Jonathan,

On 29.09.2017 14:35, Jonathan Doron wrote:
> Hi Jackek,
>
> I went over your patch but I believe it might have few issues that i
> wanted to raise before we change anything
> 1. For some reason when you are doing the "ok" test after
> CreateNamedPipe you do against != NULL should != INVALID_HANDLE_VALUE
>     this is critical... since the 2nd server might have failed with
> OBJECT_NAME_ALREADY_EXISTS
> 2. When you create the 2nd server instance against the "ok" check is
> against NULL but not only that, you check against "server" and not
> "server2"

Good catch, thanks.

> The reason I'm raising these issues is because from my understanding
> of Windows, there can be only 1 instance for a given named pipe instance,

There may be as many instances as you specify in CreateNamedPipe call.

I fixed tests to handle that properly (see attachment). And, indeed, it
looks like SD is shared between all pipe instances.

Thanks,
Jacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 7243 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20170929/18637eca/attachment-0001.bin>