[PATCH 1/2] comdlg32: Add some traces for custom Places (Coverity)

Nikolay Sivov nsivov at codeweavers.com
Sun Apr 1 03:32:23 CDT 2018


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/comdlg32/filedlg.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c
index 43d5f41180..7bed51556d 100644
--- a/dlls/comdlg32/filedlg.c
+++ b/dlls/comdlg32/filedlg.c
@@ -312,14 +312,21 @@ static void filedlg_collect_places_pidls(FileOpenDlgInfos *fodInfos)
             static const WCHAR placeW[] = {'P','l','a','c','e','%','d',0};
             WCHAR nameW[8];
             DWORD value;
+            HRESULT hr;
             WCHAR *str;
 
             sprintfW(nameW, placeW, i);
             if (get_config_key_dword(hkey, nameW, &value))
-                SHGetSpecialFolderLocation(NULL, value, &fodInfos->places[i]);
+            {
+                hr = SHGetSpecialFolderLocation(NULL, value, &fodInfos->places[i]);
+                if (FAILED(hr))
+                    WARN("Unrecognized special folder %u.\n", value);
+            }
             else if (get_config_key_string(hkey, nameW, &str))
             {
-                SHParseDisplayName(str, NULL, &fodInfos->places[i], 0, NULL);
+                hr = SHParseDisplayName(str, NULL, &fodInfos->places[i], 0, NULL);
+                if (FAILED(hr))
+                    WARN("Failed to parse custom places location, %s.\n", debugstr_w(str));
                 heap_free(str);
             }
         }
-- 
2.16.2




More information about the wine-devel mailing list