[PATCH 1/6] msi: Make MsiGetProperty() RPC-compatible.

Zebediah Figura z.figura12 at gmail.com
Tue Apr 17 00:02:13 CDT 2018


On 16/04/18 21:20, Dmitry Timoshkov wrote:
> Zebediah Figura <z.figura12 at gmail.com> wrote:
> 
>> +    r = MsiGetPropertyW(hinst, property, empty, &size);
>> +    if (r == ERROR_MORE_DATA)
>> +    {
>> +        *value = midl_user_allocate(++size * sizeof(WCHAR));
> 
> While this construct works as expected could you please avoid this kind
> of convoluted thing to make it look less tricky?
> 

Thanks for the comment. I'm not sure I really see how use of a
preincrement operator is that convoluted, but if it's felt strongly
about I'll change it.



More information about the wine-devel mailing list