[PATCH 1/2] strmbase: Update comment for copying pin info.
Zebediah Figura
z.figura12 at gmail.com
Wed Jul 4 17:43:24 CDT 2018
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
dlls/strmbase/pin.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dlls/strmbase/pin.c b/dlls/strmbase/pin.c
index ef22a57..a100ae1 100644
--- a/dlls/strmbase/pin.c
+++ b/dlls/strmbase/pin.c
@@ -145,10 +145,7 @@ out:
static void Copy_PinInfo(PIN_INFO * pDest, const PIN_INFO * pSrc)
{
- /* Tempting to just do a memcpy, but the name field is
- 128 characters long! We will probably never exceed 10
- most of the time, so we are better off copying
- each field manually */
+ /* avoid copying uninitialized data */
strcpyW(pDest->achName, pSrc->achName);
pDest->dir = pSrc->dir;
pDest->pFilter = pSrc->pFilter;
--
2.7.4
More information about the wine-devel
mailing list