[PATCH] d3d11/tests: Add test for ClearRenderTargetView.

Józef Kucia joseph.kucia at gmail.com
Wed May 16 02:04:36 CDT 2018


On Wed, May 16, 2018 at 12:37 AM, Pablo Martin <pmart-wine at riseup.net> wrote:
> On 2018-05-15 23:50, Józef Kucia wrote:
>> On Tue, May 15, 2018 at 7:09 PM, Pablo Martin <pmart-wine at riseup.net> wrote:
>>> I stumbled upon this testing problem, where the tested colour differs between wine and windows.
>>>
>>> +    todo_wine check_texture_color(test_context.backbuffer, 0x800000ff, 0);
>>
>> It doesn't seem good idea to require the exact result. 0x7f is close
>> enough to 0x80.
>
>
> I see, ok! I think the patch can safely be ignored then since there are
> similar tests in the file.
>
> Thank you, and sorry for the noob mistake. I'll take that into account
> for other patches.

Generally, if a test doesn't return the exact value on all platforms
you want to use tolerance greater than 0, e.g.

check_texture_color(test_context.backbuffer, 0x800000ff, 1);

or

check_texture_color(test_context.backbuffer, 0x800000ff, 2);



More information about the wine-devel mailing list