[PATCH] oleaut32: Fix calling function with instance and VARIANT return type.

Huw Davies huw at codeweavers.com
Tue Nov 13 10:01:56 CST 2018


On Tue, Nov 13, 2018 at 06:59:13PM +0300, Dmitry Timoshkov wrote:
> Hi Huw,
> 
> Huw Davies <huw at codeweavers.com> wrote:
> 
> > While this looks good, it would be better to add pvargResult to the
> > args array before the other args are processed (just after pvInstance
> > is added).  That would mean we could avoid all the args + 1 hacks in
> > the various call_method() calls.  I realise that would increase the
> > patch size somewhat, but we'd end up with a much cleaner function.
> > 
> > What do you think?
> 
> Could that be done as a separate patch? Frankly, since this is a patch
> from staging, and it's a pretty old one, I'd prefer to not try to go over
> it once again.

Sure.

Signed-off-by: Huw Davies <huw at codeweavers.com>



More information about the wine-devel mailing list