[PATCH] oleaut32: Fix calling function with instance and VARIANT return type.
Dmitry Timoshkov
dmitry at baikal.ru
Tue Nov 13 10:08:29 CST 2018
Huw Davies <huw at codeweavers.com> wrote:
> > > While this looks good, it would be better to add pvargResult to the
> > > args array before the other args are processed (just after pvInstance
> > > is added). That would mean we could avoid all the args + 1 hacks in
> > > the various call_method() calls. I realise that would increase the
> > > patch size somewhat, but we'd end up with a much cleaner function.
> > >
> > > What do you think?
> >
> > Could that be done as a separate patch? Frankly, since this is a patch
> > from staging, and it's a pretty old one, I'd prefer to not try to go over
> > it once again.
>
> Sure.
Thanks. Feel free to send a follow up patch with the proposed restructuring.
--
Dmitry.
More information about the wine-devel
mailing list