[PATCH 2/2] shell32/iconcache: Break as soon as one shortcut failed to overlay

[Huw Davies]

On Thu, Nov 29, 2018 at 01:50:16PM +0200, Gabriel Ivăncescu wrote:
> BTW I moved the variable definition, because I like/think it's better
> to have them as localized as possible which is better for scope
> encapsulation, it's just a coding style I follow (mostly from C++
> projects). So I'm asking for future now if I should do this kind of
> thing or it's not welcome in Wine policy unless I actually change more
> of something or refactor a function?

Generally if it's new code you can put them where you want (within reason)
although various area maintainers may have specific requests.

When making alterations to old code, adding needless style changes
makes the patch size larger and therefore harder to review.  The goal
(as I've said before) is to make it easy for the reviewer.

Huw.