[PATCH 3/4] msi/tests: Also test full range of properties for MsiSummaryInfoSetPropertyW.

[Francois Gouget]

On Wed, 19 Sep 2018, Hans Leidekker wrote:
[...]
> This is causing new test failures. The testbot fails recognize them
> however, probably because they come from custom.c instead of the test
> module that was invoked, install.c.

It does recognize them. They are even bolded orange since they are new 
failures and the summary at the top says Failures 4.

  https://testbot.winehq.org/JobDetails.pl?Key=42225#k1001


But yes, the TestBot is a bit confused because the errors don't come 
from a known test unit which is why it issues an extra error:

  msi:install contains a misplaced failure message for custom

The problem is there is no 'custom' test unit:

* You cannot run 'msi_test.exe custom'.

* There is no "xxx:custom: 123 tests executed...' summary line.

* Nothing ties 'custom' error messages to any real test unit such as 
  'install', 'action', etc. So when parsing the WineTest results there 
  is no way to know where these messages are coming from.


I don't know how to improve handling of these cases.
* The simplest for me would be if they issued 'install' errors instead 
  but that would be confusing since the error does not come from 
  install.c. So that's out.

* Maybe add a new type of line to tie custom messages to the install 
  test unit?

    0b40:install: Loading custom sub test unit.


-- 
Francois Gouget <fgouget at codeweavers.com>