[PATCH] shell32: SHCreateDirectoryExW no CANCELLED for ALREADY_EXISTS

Jactry Zeng jactry92 at gmail.com
Tue Apr 16 03:12:19 CDT 2019


Hi John,
On Tue, Apr 16, 2019 at 5:59 AM John Thomson <
git at johnthomson.fastmail.com.au> wrote:
>
> > "SHCreateDirectoryExW returned %d. Expected %d",
>
> I missed a newline at the end of one of the ok strings
>
> Should I add this newline, squash both of my commits, and submit a new
version of this patch?
> Any other hints or comments?
>

Yes, you need to send a new try.
And you will need to send your fixing and tests in one patch, or at least
in a same series.

You can check the status of your patches in
https://source.winehq.org/patches/ .

https://wiki.winehq.org/Submitting_Patches

-- 
Regards,
Jactry Zeng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190416/37ea814e/attachment.html>


More information about the wine-devel mailing list