[PATCH 1/3] cabinet/tests: Alter string declaration to include null terminator.

Chip Davis cdavis at codeweavers.com
Sun Aug 18 18:45:38 CDT 2019


August 18, 2019 5:51 PM, "Isira Seneviratne" <isirasen96 at gmail.com (mailto:%22Isira%20Seneviratne%22%20<isirasen96 at gmail.com>)> wrote:
 On Mon, Aug 19, 2019, 1:42 AM Alex Henrie <alexhenrie24 at gmail.com (mailto:alexhenrie24 at gmail.com)> wrote: + * Copyright (C) 2019 Isira Seneviratne

- static const char expected[12] = "Hello World!";
+ static const char expected[12] = {
'H','e','l','l','o','W','o','r','l','d','!','' };

All you had to do was remove the number 12 and let the compiler
determine the size of the array automatically. And you really
shouldn't add your name at the top of the file unless you wrote a
substantial chunk of the file.

-Alex    Okay, thanks.  By the way, why would the tests fail? Because you left out the space character in the string.

Chip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190818/82bb8302/attachment.html>


More information about the wine-devel mailing list