[PATCH 1/3] cabinet/tests: Alter string declaration to include null terminator.

[Isira Seneviratne]

On Mon, Aug 19, 2019, 5:15 AM Chip Davis <cdavis at codeweavers.com> wrote:

>
>
> August 18, 2019 5:51 PM, "Isira Seneviratne" <isirasen96 at gmail.com
> <%22Isira%20Seneviratne%22%20%3Cisirasen96 at gmail.com%3E>> wrote:
>
> On Mon, Aug 19, 2019, 1:42 AM Alex Henrie <alexhenrie24 at gmail.com> wrote:
>
> + * Copyright (C) 2019 Isira Seneviratne
>
> - static const char expected[12] = "Hello World!";
> + static const char expected[12] = {
> 'H','e','l','l','o','W','o','r','l','d','!','\0' };
>
> All you had to do was remove the number 12 and let the compiler
> determine the size of the array automatically. And you really
> shouldn't add your name at the top of the file unless you wrote a
> substantial chunk of the file.
>
> -Alex
>
> Okay, thanks.
> By the way, why would the tests fail?
>
> Because you left out the space character in the string.
>
> Chip
>

Thanks a lot!

Isira

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190819/b0f8202d/attachment-0001.html>