[PATCH vkd3d v3 1/2] vkd3d: Add more features to CheckFeatureSupport().

Henri Verbeet hverbeet at gmail.com
Mon Dec 2 08:03:21 CST 2019


On Wed, 27 Nov 2019 at 18:35, Conor McCarthy <cmccarthy at codeweavers.com> wrote:
>
> Some games, e.g. Hitman 2, do not check for success, and if the feature
> check is unimplemented they will use uninitialised data for the result.
>
> Signed-off-by: Conor McCarthy <cmccarthy at codeweavers.com>
> ---
> v3: Report FALSE for Native16BitShaderOpsSupported.
> Supersedes 174444.
> ---
>  include/vkd3d_d3d12.idl    | 141 +++++++++++++++++++
>  libs/vkd3d/device.c        | 279 +++++++++++++++++++++++++++++++++++++
>  libs/vkd3d/vkd3d_private.h |   5 +
>  3 files changed, 425 insertions(+)
>
It's probably best to split this into separate patches for each
option, both to keep things reviewable, and for the purpose of
bisects.

In terms of style, the existing file isn't entirely consistent about
it, but we tend to put enums together at the top, and the structures
using them together below that. Enum element values should generally
by in hexadecimal, since that's how we print them in debug messages.



More information about the wine-devel mailing list