[PATCH] oledb32: Support Milliseconds when converting BSTR -> DBTIMESTAMP

[Alistair Leslie-Hughes]

Hi Nikolay,

On 8/1/19 5:38 pm, Nikolay Sivov wrote:
>
> On 1/8/19 6:17 AM, Alistair Leslie-Hughes wrote:
>> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
>> ---
>>  
>> +            }
> I think this could reuse existing VariantChangeType() block. Also, is
> it always dot-separated? Could it depend on locale/settings? Shouldn't
> it be handled by some Variant* function instead?

Sure, I'll take a look reusing an existing Variant Function if possible
for the Date convert.

There isn't a Variant* function that deals with milliseconds on
windows.  I added a test for this scenario

(884c6ddd516478a94cd4e42ff5510ad226e69bde).  It seems to be a oledb32
only type conversion.


To my knowledge it's always dot-separated however its seems to be
database dependent if the milliseconds is included.

For example, Postgres doesn't whereas MSSQL/Firefird do.


Regards

Alistair.