[PATCH 4/5] msi: Remove an unnecessary call to SELECT_get_dimensions().

Zebediah Figura z.figura12 at gmail.com
Sat Jan 26 16:59:00 CST 2019


Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
 dlls/msi/select.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/dlls/msi/select.c b/dlls/msi/select.c
index 99339c24b8..c6e7b20903 100644
--- a/dlls/msi/select.c
+++ b/dlls/msi/select.c
@@ -233,14 +233,10 @@ static UINT SELECT_get_column_info( struct tagMSIVIEW *view, UINT n, LPCWSTR *na
 static UINT msi_select_update(struct tagMSIVIEW *view, MSIRECORD *rec, UINT row)
 {
     MSISELECTVIEW *sv = (MSISELECTVIEW*)view;
-    UINT r, i, num_columns, col, type, val;
+    UINT r, i, col, type, val;
     LPCWSTR str;
 
-    r = SELECT_get_dimensions(view, NULL, &num_columns);
-    if (r != ERROR_SUCCESS)
-        return r;
-
-    for (i = 0; i < num_columns; i++)
+    for (i = 0; i < sv->num_cols; i++)
     {
         col = sv->cols[i];
 
-- 
2.17.1




More information about the wine-devel mailing list