[PATCH 2/4] mfplat: Implement MFCreateFile().
Sven Baars
sven.wine at gmail.com
Wed Jan 30 08:35:39 CST 2019
On 30-01-19 15:03, Jactry Zeng wrote:
> @@ -545,12 +568,12 @@ static void test_MFCreateFile(void)
>
> hr = MFCreateFile(MF_ACCESSMODE_WRITE, MF_OPENMODE_FAIL_IF_NOT_EXIST,
> MF_FILEFLAGS_NONE, filename, &bytestream2);
> - todo_wine ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> + ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> if (hr == S_OK) IMFByteStream_Release(bytestream2);
>
> hr = MFCreateFile(MF_ACCESSMODE_READWRITE, MF_OPENMODE_FAIL_IF_NOT_EXIST,
> MF_FILEFLAGS_NONE, filename, &bytestream2);
> - todo_wine ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> + ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> if (hr == S_OK) IMFByteStream_Release(bytestream2);
>
> IMFByteStream_Release(bytestream);
> @@ -569,17 +592,17 @@ static void test_MFCreateFile(void)
>
> hr = MFCreateFile(MF_ACCESSMODE_READ, MF_OPENMODE_FAIL_IF_NOT_EXIST,
> MF_FILEFLAGS_NONE, newfilename, &bytestream2);
> - todo_wine ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> + ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> if (hr == S_OK) IMFByteStream_Release(bytestream2);
>
> hr = MFCreateFile(MF_ACCESSMODE_WRITE, MF_OPENMODE_FAIL_IF_NOT_EXIST,
> MF_FILEFLAGS_NONE, newfilename, &bytestream2);
> - todo_wine ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> + ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> if (hr == S_OK) IMFByteStream_Release(bytestream2);
>
> hr = MFCreateFile(MF_ACCESSMODE_WRITE, MF_OPENMODE_FAIL_IF_NOT_EXIST,
> MF_FILEFLAGS_ALLOW_WRITE_SHARING, newfilename, &bytestream2);
> - todo_wine ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> + ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> if (hr == S_OK) IMFByteStream_Release(bytestream2);
>
> IMFByteStream_Release(bytestream);
> @@ -591,11 +614,34 @@ static void test_MFCreateFile(void)
> /* Opening the file again fails even though MF_FILEFLAGS_ALLOW_WRITE_SHARING is set. */
> hr = MFCreateFile(MF_ACCESSMODE_WRITE, MF_OPENMODE_FAIL_IF_NOT_EXIST,
> MF_FILEFLAGS_ALLOW_WRITE_SHARING, newfilename, &bytestream2);
> - todo_wine ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> + ok(hr == HRESULT_FROM_WIN32(ERROR_SHARING_VIOLATION), "got 0x%08x\n", hr);
> if (hr == S_OK) IMFByteStream_Release(bytestream2);
>
Hi Jactry,
Thanks a lot for implementing this. Could you please remove all the
if (hr == S_OK) IMFByteStream_Release(bytestream2);
lines? Those were only needed for the todo_wine.
Best,
Sven
More information about the wine-devel
mailing list