[PATCH 1/3] msscript: Cache state of IActiveScript in ScriptHost struct.

[Jactry Zeng]

Hi Jacek,

Thanks for review!

I sent another try.

On 2019/5/31 下午11:42, Jacek Caban wrote:
> Hi Jactry,
>
> On 5/31/19 3:10 PM, Jactry Zeng wrote:
>>   static HRESULT WINAPI ScriptControl_AddCode(IScriptControl *iface, BSTR code)
>> @@ -985,9 +991,13 @@ static HRESULT WINAPI ScriptControl_Eval(IScriptControl *iface, BSTR expression,
>>       if (!This->host || This->state != Initialized)
>>           return E_FAIL;
>>   -    hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_STARTED);
>> -    if (FAILED(hr))
>> -        return hr;
>> +    if (This->host->script_state != SCRIPTSTATE_STARTED)
>> +    {
>> +        hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_STARTED);
>> +        if (FAILED(hr))
>> +            return hr;
>> +        This->host->script_state = SCRIPTSTATE_STARTED;
>> +    }
>
>
> This could use a helper function.
>
>
> Thanks,
>
> Jacek
>