[PATCH v2 5/8] ntdll: Clarify NtMapViewOfSection zero_bits parameter semantic

Huw Davies huw at codeweavers.com
Mon Jun 17 04:56:58 CDT 2019


On Fri, Jun 14, 2019 at 03:11:14PM +0200, RĂ©mi Bernon wrote:
>  static NTSTATUS map_image( HANDLE hmapping, ACCESS_MASK access, int fd, SIZE_T mask,
> -                           pe_image_info_t *image_info, int shared_fd, BOOL removable, PVOID *addr_ptr )
> +                           pe_image_info_t *image_info, int shared_fd, BOOL removable,
> +                           PVOID *addr_ptr, SIZE_T zero_bits )

map_image() doesn't need the mask parameter anymore.  Just call
map_view() with get_mask(0).

On a related note, it might prehaps be cleaner to have map_view() take
an alignment parameter rather than the mask (that would be changed in
a separate patch).

Huw.



More information about the wine-devel mailing list