[PATCH v4 2/6] ntdll/tests: Move NtMapViewOfSection tests from kernel32/tests

[Huw Davies]

On Thu, Jun 20, 2019 at 03:09:21PM +0200, Rémi Bernon wrote:
> On Thu, 2019-06-20 at 10:51 +0100, Huw Davies wrote:
> > On Wed, Jun 19, 2019 at 02:01:24PM +0200, Rémi Bernon wrote:
> > > +    /* for some unknown reason NtMapViewOfSection fails with
> > > STATUS_NO_MEMORY when zero_bits != 0 ? */
> > > +    ptr2 = NULL;
> > > +    size = 0;
> > > +    offset.QuadPart = 0;
> > > +    status = NtMapViewOfSection(mapping, process, &ptr2, 12, 0,
> > > &offset, &size, 1, 0, PAGE_READWRITE);
> > 
> > This is not the same as the code you've removed from kernel32.  I
> > suggest you regenerate this patch by gonig the cut-and-paste again.
> > 
> > Huw.
> 
> I thought the move was the occasion to keep the whole source file
> consistent in style, as it wasn't before. I'm not sure what's the
> policy about such changes.
> 
> I see however that there are also other test changes that I forgot to
> backport here, so is it just about that or should the code style be
> kept as well?

I was commenting on the actual tests not the style.  In particular
this test now has zero_bits back at 12.

Huw.