[PATCH 1/7] mfplat: Print warning instead of fixme for unsupported interfaces in attributes object.
Nikolay Sivov
nsivov at codeweavers.com
Fri Mar 22 01:15:13 CDT 2019
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
dlls/mfplat/main.c | 23 +++++++++--------------
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/dlls/mfplat/main.c b/dlls/mfplat/main.c
index 899aca73d9..8e9cb66058 100644
--- a/dlls/mfplat/main.c
+++ b/dlls/mfplat/main.c
@@ -651,24 +651,19 @@ static inline mfattributes *impl_from_IMFAttributes(IMFAttributes *iface)
static HRESULT WINAPI mfattributes_QueryInterface(IMFAttributes *iface, REFIID riid, void **out)
{
- mfattributes *This = impl_from_IMFAttributes(iface);
-
- TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), out);
+ TRACE("%p, %s, %p.\n", iface, debugstr_guid(riid), out);
- if(IsEqualGUID(riid, &IID_IUnknown) ||
- IsEqualGUID(riid, &IID_IMFAttributes))
+ if (IsEqualIID(riid, &IID_IMFAttributes) ||
+ IsEqualGUID(riid, &IID_IUnknown))
{
- *out = &This->IMFAttributes_iface;
- }
- else
- {
- FIXME("(%s, %p)\n", debugstr_guid(riid), out);
- *out = NULL;
- return E_NOINTERFACE;
+ *out = iface;
+ IMFAttributes_AddRef(iface);
+ return S_OK;
}
- IUnknown_AddRef((IUnknown*)*out);
- return S_OK;
+ WARN("Unsupported %s.\n", debugstr_guid(riid));
+ *out = NULL;
+ return E_NOINTERFACE;
}
static ULONG WINAPI mfattributes_AddRef(IMFAttributes *iface)
--
2.20.1
More information about the wine-devel
mailing list