[PATCH 2/2] urlmon/tests: Add FTP encoded url test
Jacek Caban
jacek at codeweavers.com
Fri Mar 22 10:58:10 CDT 2019
Hi Alistair,
On 3/22/19 5:50 AM, Alistair Leslie-Hughes wrote:
> +static const char *ftp_url;
>
> static WCHAR file_url[INTERNET_MAX_URL_LENGTH], current_url[INTERNET_MAX_URL_LENGTH];
>
> @@ -2905,7 +2907,10 @@ static void init_bind_test(int protocol, DWORD flags, DWORD t)
> url_a = (flags & BINDTEST_INVALID_CN) ?"https://4.15.184.77/favicon.ico" :"https://test.winehq.org/tests/hello.html";
> break;
> case FTP_TEST:
> - url_a ="ftp://ftp.winehq.org/welcome.msg";
> + if(!ftp_url)
> + url_a ="ftp://ftp.winehq.org/welcome.msg";
> + else
> + url_a = ftp_url;
Is there any reason to run almost the same tests twice? FTP tests are
rather slow. Could you just change current test to use escaped URL?
Thanks,
Jacek
More information about the wine-devel
mailing list