[PATCH 1/2] xaudio2: Fix support for FAudio 19.06 and newer

[Ethan Lee]

>That’s not an improvement.

Does this mean I can go back to my original plan then? This really sucks, I get it, but if we can’t come up with some kind of compromise to make this as un-sucky as possible then I’ll go with what my other users will understand the best by default. They can handle breakages WAY better by the sound of it, so if it’s really that painful then I need to start seeing some suggestions for a real plan other than “leave the catastrophic bug in” which benefits literally nobody but Wine’s build (not even Wine as a whole, just the build).

-Ethan

> On May 2, 2019, at 5:17 PM, Alexandre Julliard <julliard at winehq.org> wrote:
> 
> Ethan Lee <elee at codeweavers.com <mailto:elee at codeweavers.com>> writes:
> 
>> Those names definitely look messy, but not quite messy enough… I’ll keep thinking of a good name, but for now (at least for demonstration purposes) I’ve gone ahead and used ‘BADABI’ to lay out how this is going to go down:
>> 
>> https://github.com/FNA-XNA/FAudio/blob/16d1dfeb92a4ae18eacb67c3dcf3f75de5135fc4/include/FAudio.h#L662
>> 
>> https://github.com/FNA-XNA/FAudio/blob/16d1dfeb92a4ae18eacb67c3dcf3f75de5135fc4/include/FAPOFX.h#L159
>> 
>> So I’ve added the fixed functions and that’ll work for the rest of
>> 2019 - this can safely be used for all of Wine 4.x and 5.0, and the
>> function used by 4.3 through 4.7 (or 8 or 9, depending on when you
>> want to move to the corrected function) can still build against the
>> old function. It won’t work (and absolutely positively never will and
>> never could have worked, just to emphasize one more time), but it’s at
>> least there for compilation purposes. By the time 5.0 is out the
>> proper function will be available and the 5.x series can use the new
>> function, while 5.0.x maintenance releases can continue to use the
>> BADABI function safely without having to worry about it getting lost
>> before 6.0 is out. Once 6.0 is out, both the stable/unstable branches
>> of Wine will be on the right function and the old functions won’t
>> apply at that point.
> 
> That's not an improvement. You should not be planning to break the ABI
> ever, and certainly not on a yearly basis.
> 
> It's unfortunate that you can't name it FAudio_CommitChanges because
> that name is taken by the old one, but you should get over it, pick a
> proper name, and plan on maintaining it forever. There's no reason to
> rename it again next year, that's just gratuitous breakage.
> 
> -- 
> Alexandre Julliard
> julliard at winehq.org <mailto:julliard at winehq.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190502/76deb31a/attachment-0001.html>