[PATCH 1/2] xaudio2: Fix support for FAudio 19.06 and newer

[Zebediah Figura]

On 5/2/19 7:46 PM, Ethan Lee wrote:
>  >That’s not an improvement.
> 
> Does this mean I can go back to my original plan then? This really 
> sucks, I get it, but if we can’t come up with some kind of compromise to 
> make this as un-sucky as possible then I’ll go with what my other users 
> will understand the best by default. They can handle breakages WAY 
> better by the sound of it, so if it’s really that painful then I need to 
> start seeing some suggestions for a real plan other than “leave the 
> catastrophic bug in” which benefits literally nobody but Wine’s build 
> (not even Wine as a whole, just the build).
> 

What exactly is the "catastrophic bug" here? That CommitChanges() won't 
do anything? That was already the case; why is it suddenly worse now 
that a working implementation exists? Or that it has the wrong 
signature? Why is that catastrophic then, if it doesn't do anything anyway?