[PATCH] wininet/tests: Skip some FTP tests when no connection can be made.
Sven Baars
sven.wine at gmail.com
Thu Oct 24 13:21:22 CDT 2019
Signed-off-by: Sven Baars <sven.wine at gmail.com>
---
This happens quite often, see
https://test.winehq.org/data/tests/wininet:ftp.html
Also during bbf74ea22a5310978c9aecbdc648c562c26fa0fb
the behavior of this test was changed, so I modified the
comments accordingly.
dlls/wininet/tests/ftp.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/dlls/wininet/tests/ftp.c b/dlls/wininet/tests/ftp.c
index 317b291495..c6d972a352 100644
--- a/dlls/wininet/tests/ftp.c
+++ b/dlls/wininet/tests/ftp.c
@@ -63,7 +63,7 @@ static void test_connect(HINTERNET hInternet)
HINTERNET hFtp;
/* Try a few username/password combinations:
- * anonymous : NULL
+ * anonymous : IEUser@
* NULL : IEUser@
* NULL : NULL
* "" : IEUser@
@@ -72,14 +72,14 @@ static void test_connect(HINTERNET hInternet)
SetLastError(0xdeadbeef);
hFtp = InternetConnectA(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "anonymous", "IEUser@", INTERNET_SERVICE_FTP, INTERNET_FLAG_PASSIVE, 0);
- if (hFtp) /* some servers accept an empty password */
+ if (!hFtp)
{
- ok ( GetLastError() == ERROR_SUCCESS, "ERROR_SUCCESS, got %d\n", GetLastError());
- InternetCloseHandle(hFtp);
+ skip("No ftp connection could be made to ftp.winehq.org %u\n", GetLastError());
+ return;
}
- else
- ok ( GetLastError() == ERROR_INTERNET_LOGIN_FAILURE,
- "Expected ERROR_INTERNET_LOGIN_FAILURE, got %d\n", GetLastError());
+ ok(GetLastError() == ERROR_SUCCESS,
+ "Expected ERROR_SUCCESS, got %d\n", GetLastError());
+ InternetCloseHandle(hFtp);
SetLastError(0xdeadbeef);
hFtp = InternetConnectA(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, NULL, "IEUser@", INTERNET_SERVICE_FTP, INTERNET_FLAG_PASSIVE, 0);
--
2.17.1
More information about the wine-devel
mailing list