[PATCH 1/3] advapi32/tests: Change sprintf to PathCombineA to avoid GCC warnings

Alex Henrie alexhenrie24 at gmail.com
Sat Sep 7 13:25:50 CDT 2019


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 dlls/advapi32/tests/Makefile.in | 2 +-
 dlls/advapi32/tests/service.c   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/dlls/advapi32/tests/Makefile.in b/dlls/advapi32/tests/Makefile.in
index 12583e59f5..83c9c1d91c 100644
--- a/dlls/advapi32/tests/Makefile.in
+++ b/dlls/advapi32/tests/Makefile.in
@@ -1,5 +1,5 @@
 TESTDLL   = advapi32.dll
-IMPORTS   = ole32 advapi32
+IMPORTS   = ole32 advapi32 shlwapi
 
 C_SRCS = \
 	cred.c \
diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c
index 9dad710490..0059b4ae40 100644
--- a/dlls/advapi32/tests/service.c
+++ b/dlls/advapi32/tests/service.c
@@ -29,6 +29,7 @@
 #include "winnls.h"
 #include "lmcons.h"
 #include "aclapi.h"
+#include "shlwapi.h"
 
 #include "wine/test.h"
 
@@ -212,9 +213,9 @@ static void test_create_delete_svc(void)
     GetUserNameA(username, &user_size);
     /* Get the domainname to cater for that situation */
     if (GetEnvironmentVariableA("USERDOMAIN", domain, MAX_PATH))
-        sprintf(account, "%s\\%s", domain, username);
+        PathCombineA(account, domain, username);
     else
-        sprintf(account, ".\\%s", username);
+        PathCombineA(account, ".", username);
 
     /* All NULL */
     SetLastError(0xdeadbeef);
-- 
2.23.0




More information about the wine-devel mailing list