[PATCH] winedbg: Fix dependence on undefined left-shift behavior (scan-build)

Alex Henrie alexhenrie24 at gmail.com
Wed Sep 11 22:05:15 CDT 2019


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 programs/winedbg/be_x86_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/winedbg/be_x86_64.c b/programs/winedbg/be_x86_64.c
index 136229fbd6..2346bc4d1f 100644
--- a/programs/winedbg/be_x86_64.c
+++ b/programs/winedbg/be_x86_64.c
@@ -640,7 +640,7 @@ static BOOL be_x86_64_fetch_integer(const struct dbg_lvalue* lvalue, unsigned si
     if (!memory_read_value(lvalue, size, ret)) return FALSE;
 
     /* propagate sign information */
-    if (is_signed && size < 16 && (*ret >> (size * 8 - 1)) != 0)
+    if (is_signed && size < sizeof(*ret) && (*ret >> (size * 8 - 1)) != 0)
     {
         ULONGLONG neg = -1;
         *ret |= neg << (size * 8);
-- 
2.23.0




More information about the wine-devel mailing list