RFC: TestBot priorities

Gabriel Ivăncescu gabrielopcode at gmail.com
Fri Apr 3 07:08:26 CDT 2020


On 03/04/2020 14:39, Zhiyi Zhang wrote:
> 
> 
> On 4/3/20 6:09 PM, Francois Gouget wrote:
>> On Fri, 3 Apr 2020, Zhiyi Zhang wrote:
>> [...]
>>> I think we can only enable -Werror for patches coming from the
>>> wine-devel.
>> Do you have a concrete proposal?
> We could consider switching to clean build with ccache set up.
> So a separate tree is not needed. That would solve the problem
> of having to wait for nightly VM updates to complete for some
> patches as well since we don't have to update those VMs then.
> This will of course increase the TestBot workload a lot. But should
> be feasible after the 3900x upgrade.
> 
> Thanks,
> Zhiyi
> 
>>
>>> It's indeed making tests more inconvenient. Sometimes, you just want
>>> to comment out a large part of code and only test a specific spot.
>> That's where if (0) comes in.
>>
>>
> 
> 

An alternative is to just print a summary of warnings and not actually 
fail the test because of them. Whoever is interested in the warnings can 
then easily spot them. It requires more work, though.



More information about the wine-devel mailing list