[PATCH v2] amstream: Implement IMediaStreamFilter::ReferenceTimeToStreamTime().

Gijs Vermeulen gijsvrm at gmail.com
Tue Aug 25 13:17:03 CDT 2020


Hi Zeb,

Thanks for the review.

Op di 25 aug. 2020 om 17:16 schreef Zebediah Figura <z.figura12 at gmail.com>:

> A brief test shows that the function crashes if you pass NULL time while
> there's a valid clock, so I think you can just get rid of this check.


While I definitely don't feel strongly about this, elsewhere in amstream we
check for NULL on things that crash on native
(IAMMediaStream::Initialize(),
IMediaStreamFilter::GetCurrentStreamTime()/GetState
to name a few).

Kind regards,
Gijs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200825/7168be72/attachment.htm>


More information about the wine-devel mailing list