[PATCH v2] amstream: Implement IMediaStreamFilter::ReferenceTimeToStreamTime().

[Zebediah Figura]

On 8/25/20 1:17 PM, Gijs Vermeulen wrote:
> Hi Zeb,
> 
> Thanks for the review.
> 
> Op di 25 aug. 2020 om 17:16 schreef Zebediah Figura
> <z.figura12 at gmail.com <mailto:z.figura12 at gmail.com>>:
> 
>     A brief test shows that the function crashes if you pass NULL time while
>     there's a valid clock, so I think you can just get rid of this check.
> 
> 
> While I definitely don't feel strongly about this, elsewhere in amstream
> we check for NULL on things that crash on native
> (IAMMediaStream::Initialize(), IMediaStreamFilter::GetCurrentStreamTime()/GetState
> to name a few). 

Personally I wouldn't have put those checks in the implementation, but I
don't care enough to reject the patch.

If we are going to add such a check, though, it should probably return
E_POINTER instead of S_FALSE.

> 
> Kind regards,
> Gijs 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200825/ed10395e/attachment.sig>