[PATCH] crypt32: Fix reading and writing CRYPT_KEY_PROV_INFO certificate property.

Alexandre Julliard julliard at winehq.org
Thu Dec 3 10:41:26 CST 2020


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Alexandre Julliard <julliard at winehq.org> wrote:
>
>> > Is there anything that could be improved to make this patch accepted?
>> 
>> It's fairly large, it would help if you could do this in smaller chunks
>> somehow.
>
> The patch implements both serializer and deserializer of the CRYPT_KEY_PROV_INFO
> property, and that can't be split without breaking too much. I can send the tests
> separately though. Is that acceptable?

That's a first step but it would be good to split further, the hard to
review bits are not the tests.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list