[PATCH] crypt32: Fix reading and writing CRYPT_KEY_PROV_INFO certificate property.

[Dmitry Timoshkov]

Alexandre Julliard <julliard at winehq.org> wrote:

> >> > Is there anything that could be improved to make this patch accepted?
> >> 
> >> It's fairly large, it would help if you could do this in smaller chunks
> >> somehow.
> >
> > The patch implements both serializer and deserializer of the CRYPT_KEY_PROV_INFO
> > property, and that can't be split without breaking too much. I can send the tests
> > separately though. Is that acceptable?
> 
> That's a first step but it would be good to split further, the hard to
> review bits are not the tests.

Unfortunately I don't see a way to separate serializer and deserializer,
missing any of them would lead to major breakage. The tests are supposed
to verify the implemented functionality, perhaps that could mitigate
the patch size.

-- 
Dmitry.