[PATCH] ddraw/tests: Reverse cleanup order in test_coop_level_threaded().

Sven Baars sbaars at codeweavers.com
Sun Feb 2 07:45:52 CST 2020


Signed-off-by: Sven Baars <sbaars at codeweavers.com>
---
This fixes a crash on my system.

 dlls/ddraw/tests/ddraw1.c | 2 +-
 dlls/ddraw/tests/ddraw2.c | 2 +-
 dlls/ddraw/tests/ddraw4.c | 2 +-
 dlls/ddraw/tests/ddraw7.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c
index 16c0cfb4e5..45a24e3ffb 100644
--- a/dlls/ddraw/tests/ddraw1.c
+++ b/dlls/ddraw/tests/ddraw1.c
@@ -1254,8 +1254,8 @@ static void test_coop_level_threaded(void)
     hr = IDirectDraw_SetCooperativeLevel(ddraw, p.window, DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN);
     ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
 
-    IDirectDraw_Release(ddraw);
     destroy_window_thread(&p);
+    IDirectDraw_Release(ddraw);
 }
 
 static ULONG get_refcount(IUnknown *test_iface)
diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c
index f0ae458d85..3fccd02f1e 100644
--- a/dlls/ddraw/tests/ddraw2.c
+++ b/dlls/ddraw/tests/ddraw2.c
@@ -1142,8 +1142,8 @@ static void test_coop_level_threaded(void)
     hr = IDirectDraw2_SetCooperativeLevel(ddraw, p.window, DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN);
     ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
 
-    IDirectDraw2_Release(ddraw);
     destroy_window_thread(&p);
+    IDirectDraw2_Release(ddraw);
 }
 
 static void test_depth_blit(void)
diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c
index b6cb97c3c9..d97834e542 100644
--- a/dlls/ddraw/tests/ddraw4.c
+++ b/dlls/ddraw/tests/ddraw4.c
@@ -1314,8 +1314,8 @@ static void test_coop_level_threaded(void)
     hr = IDirectDraw4_SetCooperativeLevel(ddraw, p.window, DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN);
     ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
 
-    IDirectDraw4_Release(ddraw);
     destroy_window_thread(&p);
+    IDirectDraw4_Release(ddraw);
 }
 
 static void test_depth_blit(void)
diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c
index 0afbe76b6c..bbc61087ca 100644
--- a/dlls/ddraw/tests/ddraw7.c
+++ b/dlls/ddraw/tests/ddraw7.c
@@ -1268,8 +1268,8 @@ static void test_coop_level_threaded(void)
     hr = IDirectDraw7_SetCooperativeLevel(ddraw, p.window, DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN);
     ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
 
-    IDirectDraw7_Release(ddraw);
     destroy_window_thread(&p);
+    IDirectDraw7_Release(ddraw);
 }
 
 static void test_depth_blit(void)
-- 
2.24.0




More information about the wine-devel mailing list