[PATCH v2 1/2] kernel32/tests: Add tests for LCMapStringW

Fabian Maurer dark.shadow4 at web.de
Thu Feb 13 09:44:08 CST 2020


Hello Alexandre,

> This clearly needs to be a table of some kind.

Sure thing, I can make the tests use a table, like some other string tests do.

> Also you should find a
> way to test all Windows versions, preferably without having to hardcode
> a ton of sortkey values for every version.

Unfortunately, this won't be possible. The sortkey values differ from windows
version to version, so we have to either test only one windows version, or add
tables for all windows versions.

I planned to just add the Win7 table and use that for wine. There are
incompatibilities for different windows versions, but for most applications
the Win7 table should work - especially when speaking about just comparing
instead of really needing the sortkey directly.
Since Win7 is discontinued, I don't expect changes to those tables, that's why
I picked that one.

I'll try to make the table compressed like the others, so it does take up less
space though.

Regards,
Fabian Maurer






More information about the wine-devel mailing list