[PATCH v2 1/3] ddraw/tests: Test non-primary surface in test_lost_device.

[Gabriel Ivăncescu]

On 28/07/2020 13:37, Henri Verbeet wrote:
> On Mon, 27 Jul 2020 at 22:06, Gabriel Ivăncescu <gabrielopcode at gmail.com> wrote:
>> On 27/07/2020 19:30, Stefan Dösinger wrote:
>>> This will either create a video or system memory surface depending on
>>> the whims of the driver. Since we already explicitly test offscreen
>>> sysmem surfaces, shouldn't this one request video memory explicitly and
>>> skip some tests if creation fails? That might make your broken(hr ==
>>> DD_OK) /* WinXP */ go away.
>>>
>> You're right, sorry, I'm not very familiar with ddraw. I tried with
>> DDSCAPS_VIDEOMEMORY (and even DDSCAPS_LOCALVIDMEM, though it shouldn't
>> be necessary), unfortunately it's still broken on Windows XP so that
>> broken check has to stay.
>>
> Why do you consider the Windows XP result broken? DD_OK is what I
> would expect for DDSCL_NORMAL.
> 

Well, I thought it's broken because it only applies to ddraw1 and on Win 
XP (not on Windows 7). The other ddraw have the same behavior as other 
Windows OSes and fail, too. So it seemed like the odd one out.