[PATCH] comctl32: Initialize early some edit control properties.
nsivov at codeweavers.com
Wed Mar 25 06:37:40 CDT 2020
On 3/25/20 2:12 PM, Roman Pišl wrote:
> Hello Nikolay,
> bug 37144 is also marked as user32 and closed as duplicate of 19239
> but also fixed by this. Should I mention the bug 37144 in commit
> message or will be properly re-closed in bugzilla?
It's better to mention ones that you tested. Those bugs are older than
class redirection functionality, that's why it's confusing. If it turns
out that all of them are using redirected classes,
we'll switch components accordingly.
> My thought was - make the initialization early, it can't hurt
> anything, but it is also obvious that EDIT_EM_EmptyUndoBuffer is
> useless - the buffer is already zeroed by heap_alloc_zero() so the
> removal is intentional. Should I put it back to WM_Create?
Right, I'm not suggesting this fix is incorrect, but it's important to
have a test so we don't break it again. And yes, please keep
EmptyUndoBuffer where it is, it's unrelated.
More information about the wine-devel