[PATCH] winegstreamer: Fixup raw audio caps to be compatible with IMFMediaType.

Zebediah Figura z.figura12 at gmail.com
Fri Nov 6 14:32:19 CST 2020


On 11/6/20 2:20 PM, Derek Lesho wrote:
> On 11/6/20 2:13 PM, Zebediah Figura wrote:
> 
>> This is done in a rather inconsistent way relative to how video streams
>> are handled.
> Yes, because the goals are different for each of the paths.  The video
> path is just an enhancement to report video formats in a defined order
> as if they were coming from a decoder, since right now we're skipping
> the decoder MFT step.  The step for fixing up the audio caps is meant to
> be a generic solution for any caps which are un-representable as a
> IMFMediaType object.  This same path is used for compressed h.264 video
> on my local branch for example.
> 

In both cases you're doing conversion from a type which may not be
representable into a type which is. The reasons for doing this
conversion may be different, but there is no reason for the mechanism to be.

Moreover, the goals are not entirely orthogonal; not all video will be
output in the four types you have listed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20201106/538f1939/attachment.sig>


More information about the wine-devel mailing list