[PATCH v3 2/5] d3dcompiler: Add stub ID3D12ShaderReflection interface.

Matteo Bruni matteo.mystral at gmail.com
Tue Sep 1 09:43:08 CDT 2020


On Tue, Aug 11, 2020 at 2:31 PM Paul Gofman <pgofman at codeweavers.com> wrote:
>
> Signed-off-by: Paul Gofman <pgofman at codeweavers.com>
> ---
> v2:
>     - fix reflection test in d3d10.
> v3:
>     - show in test that QueryInterface between ID3D11.../ID3D12ShaderReflection returns the same interface pointer.

I had also noticed that the d3d11 and d3d12 interfaces coincide. It's
an implementation detail and it seems very unlikely that any
application depends on it, thus your implementation is certainly fine
as far as I'm concerned. I'm curious though how would it look without
the duplication. GetResourceBindingDesc[ByName]() will need some care,
but that's the case either way.
Bottom line, I'd like to see some patches for the alternative version
and, if it doesn't look too terrible, probably go with that. If you
already tried and it didn't feel right that's good enough for me.



More information about the wine-devel mailing list