[PATCH v3 1/5] d3dcompiler: Rename ID3D11ShaderReflection functions to d3d11_... from d3dcompiler_...

Paul Gofman pgofman at codeweavers.com
Tue Sep 1 10:01:57 CDT 2020


On 9/1/20 17:42, Matteo Bruni wrote:
> First of all, sorry for the huge delay.
>
> The patch is a bit awkward in that it's basically just style cleanup
> and those are generally frowned upon. Also maybe we don't want to use
> separate methods for d3d11 and d3d12 (more on that in reply to the
> next patch).
> It is a big cleanup though and I don't really want to waste your time
> reworking it...

The only motivation for this patch was the case if we want to use 
separate methods. In this case it would be natutal to have d3dcompiler_ 
methods called from different d3d interface versions. Otherwise it would 
become overly messy if we have d3dcompiler_ for d3d11, d3d12_ for d3d12 
and something else for common functions. If we go aliasing interfaces I 
guess this patch is not needed.




More information about the wine-devel mailing list